Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 241 > > > > > > My usual pattern for dealing with socket addresses is to use a union, > > which avoids the

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review157341 --- A small followup commit: ``` commit 727cbef97a3a1a51abf0d2df9076ea

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 29, 2016, 8:22 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 28, 2016, 10:08 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 433 > > > > > > inline is not necessary for template specification? Let's be consistent > > here (either use inl

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 129 > > > > > > Suggest that this should be `explicit`. There's some risk that strings > > like `127.0.0.1

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review157097 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/addr

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 28, 2016, 6:15 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 53460: Refactored network::Address into inet::Address.

> On Nov. 20, 2016, 11:31 p.m., James Peach wrote: > > 3rdparty/libprocess/include/process/address.hpp, line 138 > > > > > > You should bounds-check the path here since, `sun_path` is only 108 > > bytes. Also, this

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review156427 --- 3rdparty/libprocess/include/process/address.hpp (line 124)

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 4, 2016, 5:30 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 4, 2016, 7:41 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 4, 2016, 7:33 a.m.) Review request for mesos, Benjamin Mahler and

Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos Descr