Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/ --- (Updated Nov. 8, 2016, 1:51 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/ --- (Updated Nov. 8, 2016, 1:06 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/ --- (Updated Nov. 8, 2016, 1:05 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/#review155190 --- Ship it! Ship It! - Vinod Kone On Nov. 4, 2016, 7:08 a.m.,

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-04 Thread Jie Yu
> On Nov. 4, 2016, 5:53 p.m., Kevin Klues wrote: > > src/tests/mesos.hpp, lines 1867-1875 > > > > > > This seems like a logically different change that should have its own > > commit message explaining why this is

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-04 Thread Jie Yu
> On Nov. 4, 2016, 5:53 p.m., Kevin Klues wrote: > > src/tests/mesos.hpp, line 365 > > > > > > Why is this pulled in if it's now used anywhere? Does some of the macro > > magic below actually reference this type?

Re: Review Request 53466: Added test to verify container status for nested containers.

2016-11-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/#review154946 --- src/tests/mesos.hpp (line 365)

Review Request 53466: Added test to verify container status for nested containers.

2016-11-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53466/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: MESOS-6465 and