Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156908 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 25, 2016,

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 24, 2016, 6:34 p.m., Alexander Rukletsov wrote: > > src/tests/utils.hpp, line 80 > > > > > > #include Even though this is the correct header for C++ code like we have here, we seem to widely prefer

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 25, 2016, 10:05 a.m.) Review request for mesos, Alexander

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156860 --- src/tests/utils.hpp (line 77)

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 23, 2016, 2:20 a.m., haosdent huang wrote: > > src/tests/utils.cpp, line 82 > > > > > > Should we move the comment > > > > ``` > > // Bind to port 0 to obtain a random unused port. > > ```

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 23, 2016, 3:20 a.m., haosdent huang wrote: > > src/tests/utils.cpp, line 82 > > > > > > Should we move the comment > > > > ``` > > // Bind to port 0 to obtain a random unused port. > > ```

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156691 --- Fix it, then Ship it! Ship It! src/tests/utils.cpp (line 82)

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156588 --- Ship it! Ship It! - Gastón Kleiman On Nov. 22, 2016, 3:49

Re: Review Request 53949: Added test helper to obtain unused port.

> On Nov. 22, 2016, 2:44 p.m., haosdent huang wrote: > > src/tests/utils.cpp, lines 96-97 > > > > > > Should we have a maximum failure limit here? > > > > Another way to get a free port is to bind the socket

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 22, 2016, 4:49 p.m.) Review request for mesos, Alexander

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 22, 2016, 4:39 p.m.) Review request for mesos, Alexander

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/#review156567 --- src/tests/utils.cpp (lines 96 - 97)

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 21, 2016, 7:43 p.m.) Review request for mesos and Alexander

Re: Review Request 53949: Added test helper to obtain unused port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53949/ --- (Updated Nov. 21, 2016, 7:40 p.m.) Review request for mesos and Alexander