Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 25, 2016, 11:56 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 25, 2016, 11:52 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-24 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156869 --- Ship it! Ship It! - Gastón Kleiman On Nov. 23, 2016, 1:11

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156807 --- Ship it! Ship It! - haosdent huang On Nov. 23, 2016, 1:11

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156773 --- Patch looks great! Reviews applied: [52863, 52864, 52865, 54004,

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-23 Thread haosdent huang
> On Nov. 23, 2016, 4:10 a.m., haosdent huang wrote: > > src/health-check/health_checker.cpp, line 213 > > > > > > No sure if `check.SerializeAsString()` would be better or not. Or we > > could add a `stringify()`

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/#review156700 --- src/health-check/health_checker.cpp (line 213)

Re: Review Request 54007: Printed complete health check configuration on task launch.

2016-11-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- (Updated Nov. 23, 2016, 1:11 a.m.) Review request for mesos, Gastón Kleiman

Review Request 54007: Printed complete health check configuration on task launch.

2016-11-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54007/ --- Review request for mesos, Gastón Kleiman and haosdent huang. Repository: mesos