Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- Review request for mesos, Benjamin Mahler and Guangya Liu. Repository: mesos

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Dec. 28, 2016, 4:32 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160217 --- src/common/protobuf_utils.hpp (line 209)

Re: Review Request 55021: Added a framework capabilities struct.

> On Dec. 28, 2016, 5:24 p.m., Guangya Liu wrote: > > src/common/protobuf_utils.hpp, line 209 > > > > > > You may need a default constructor for `Capabilities` here, otherwise, > > the `hierarhical.cpp` will be fail

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Dec. 29, 2016, 9:37 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55021: Added a framework capabilities struct.

> On 十二月 28, 2016, 9:24 a.m., Guangya Liu wrote: > > src/common/protobuf_utils.hpp, lines 238-243 > > > > > > I'd like we keep a comment for each of the capability here and also > > keep the variable same as before.

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Jan. 5, 2017, 8:19 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160591 --- src/common/protobuf_utils.hpp (line 44)

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160599 --- While looking at https://reviews.apache.org/r/55068/, should we al

Re: Review Request 55021: Added a framework capabilities struct.

> On Jan. 5, 2017, 4:52 p.m., Benjamin Bannier wrote: > > While looking at https://reviews.apache.org/r/55068/, should we also update > > `mesos::internal::protobuf::frameworkHasCapability` here? Please disregard this comment, I got confused about the use value types. - Benjamin ---

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Jan. 6, 2017, 3:21 p.m.) Review request for mesos, Benjamin Bannier, B

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review161604 --- Fix it, then Ship it! Looks good, just a few minor suggestions

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review161610 --- src/tests/protobuf_utils_tests.cpp (line 65)