Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2017-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/#review161996 --- Ship it! I plan to update the commit summary to: ``` Windows:

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/ --- (Updated Jan. 15, 2017, 10:23 a.m.) Review request for mesos, Andrew

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2017-01-11 Thread Alex Clemmer
> On Jan. 11, 2017, 2:09 a.m., Joseph Wu wrote: > > The change LGTM, but it might need a rebase due to some changes BenH made > > to the same file. And MPark will also be committing a change to this file > > soon (related to `io::peek`). > > > > A few things to note: > > > > * Why not make

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2017-01-11 Thread Joseph Wu
> On Jan. 10, 2017, 6:09 p.m., Joseph Wu wrote: > > The change LGTM, but it might need a rebase due to some changes BenH made > > to the same file. And MPark will also be committing a change to this file > > soon (related to `io::peek`). > > > > A few things to note: > > > > * Why not make

Re: Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2017-01-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/#review161170 --- The change LGTM, but it might need a rebase due to some changes

Review Request 55022: Windows: Cause errors to be correctly reported in `io::read`.

2016-12-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55022/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich,