Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2016-12-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2016-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/#review160161 --- Fix it, then Ship it! While the below might never be implemente

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-11 Thread Joseph Wu
> On Dec. 27, 2016, 6:12 a.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/launch.cpp, line 148 > > > > > > By not adding `syswow64` we are excluding 32bit runnables, is this > > intentional and document

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-15 Thread Alex Clemmer
> On Dec. 27, 2016, 2:12 p.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/launch.cpp, line 148 > > > > > > By not adding `syswow64` we are excluding 32bit runnables, is this > > intentional and document

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9 a.m.) Review request for mesos, Andrew Schwartzmeyer,

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9:02 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 9:22 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 15, 2017, 10:17 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/#review162010 --- This helper method belongs in stout, as it is precisely something

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:06 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:09 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/ --- (Updated Jan. 19, 2017, 2:13 a.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55037/#review162525 --- Ship it! The review description here is now out-of-date. Somet

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-20 Thread Alex Clemmer
> On Jan. 21, 2017, 12:30 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 53 > > > > > > This looks like an erroneous addition. This doesn't appear in my source file, and when I push it does