Re: Review Request 55321: Introduced process::after.

2017-02-03 Thread Benjamin Hindman
> On Feb. 2, 2017, 11:19 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/after.hpp, line 51 > > > > > > We keep two copies of a shared pointer to `promise` in an `onDiscard` > > callback

Re: Review Request 55321: Introduced process::after.

2017-02-03 Thread Benjamin Hindman
> On Feb. 2, 2017, 11:26 a.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/Makefile.am, line 237 > > > > > > Shouldn't we update the cmake lists as well? Thanks! - Benjamin

Re: Review Request 55321: Introduced process::after.

2017-02-03 Thread Benjamin Hindman
> On Feb. 1, 2017, 4:38 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/after.hpp, lines 50-55 > > > > > > I was trying to wrap my head around whether this created a bad circular > > reference

Re: Review Request 55321: Introduced process::after.

2017-02-02 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163959 --- 3rdparty/libprocess/Makefile.am (line 237)

Re: Review Request 55321: Introduced process::after.

2017-02-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163955 --- 3rdparty/libprocess/include/Makefile.am (lines 15 - 16)

Re: Review Request 55321: Introduced process::after.

2017-02-01 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163833 --- 3rdparty/libprocess/include/process/after.hpp (line 25)

Re: Review Request 55321: Introduced process::after.

2017-02-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163825 --- 3rdparty/libprocess/include/process/after.hpp (lines 50 - 55)

Re: Review Request 55321: Introduced process::after.

2017-01-31 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/#review163778 --- Ship it! Nice to have! I wonder if we still want delay long

Review Request 55321: Introduced process::after.

2017-01-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55321/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---