Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/#review162558 --- Ship it! Ship It! - Vinod Kone On Jan. 20, 2017, 2:49 p.m.,

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 20, 2017, 2:49 p.m.) Review request for mesos, Gastón Kleiman, ha

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 19, 2017, 5:41 p.m.) Review request for mesos, Gastón Kleiman, ha

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 18, 2017, 10:39 a.m.) Review request for mesos, Gastón Kleiman, h

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/#review162061 --- src/launcher/executor.cpp (line 17)

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- (Updated Jan. 18, 2017, 9:31 a.m.) Review request for mesos, Gastón Kleiman, ha

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-16 Thread Alexander Rukletsov
> On Jan. 13, 2017, 12:33 p.m., Gastón Kleiman wrote: > > src/launcher/executor.cpp, line 82 > > > > > > According to our style guide, this should be the first include =) Good catch! - Alexander -

Re: Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-13 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/#review161512 --- src/launcher/executor.cpp (line 79)

Review Request 55456: Fixed include order in "launcher/executor.cpp".

2017-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Repos