Re: Review Request 55683: Rationalize process wait error checking.

2017-01-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/#review162272 --- Patch looks great! Reviews applied: [55683] Passed command: expo

Re: Review Request 55683: Rationalize process wait error checking.

2017-01-18 Thread James Peach
> On Jan. 19, 2017, 12:43 a.m., Jiang Yan Xu wrote: > > src/launcher/fetcher.cpp, line 114 > > > > > > It's worth noting that > > > > ``` > > !WSUCCESS() > > ``` > > > > translates to > >

Re: Review Request 55683: Rationalize process wait error checking.

2017-01-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/ --- (Updated Jan. 19, 2017, 1:11 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55683: Rationalize process wait error checking.

2017-01-18 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/#review162196 --- Fix it, then Ship it! src/common/status_utils.hpp (line 26)

Re: Review Request 55683: Rationalize process wait error checking.

2017-01-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/#review162188 --- Patch looks great! Reviews applied: [55683] Passed command: expo

Review Request 55683: Rationalize process wait error checking.

2017-01-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55683/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, Michael Park,