Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

2017-01-19 Thread Joseph Wu
> On Jan. 19, 2017, 6:08 a.m., Benjamin Bannier wrote: > > Looking through other instances of `spawn(.*,\ true)`, should this one also > > be adjusted, > > https://github.com/apache/mesos/blob/745b3c7589e5252cf93f62e081b78fa420771d0c/3rdparty/libprocess/include/process/loop.hpp#L134-L144? I'll

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

2017-01-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162283 --- Ship it! Looking through other instances of `spawn(.*,\ true)`,

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

2017-01-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162279 --- Patch looks great! Reviews applied: [55701] Passed command: expo

Re: Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

2017-01-18 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/#review162234 --- Ship it! Ship It! - Benjamin Mahler On Jan. 19, 2017, 2:41 a

Review Request 55701: Fixed unsafe usage of process pointer in async.hpp.

2017-01-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55701/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler, a