Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

> On Jan. 19, 2017, 3:23 p.m., James Peach wrote: > > src/linux/fs.cpp, line 103 > > > > > > Can you make this `static const`? Should be fine using hashmap. Adding static const for hashmap would cause overloaded op

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

> On Jan. 19, 2017, 11:23 p.m., James Peach wrote: > > src/linux/fs.hpp, line 244 > > > > > > I get the analogy that leads to `magic`, but I'd prefer that it was > > named something more obvious. Maybe `typeName()`?

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/ --- (Updated Jan. 19, 2017, 3:33 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/#review162354 --- src/linux/fs.hpp (line 152)

Review Request 55714: Added fs::magic() mapping function for fs id to fs type mapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/ --- Review request for mesos, Avinash sridharan, Jie Yu, Timothy Chen, and Jiang Yan