Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 12, 2017, 10:13 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 157-158 (original), 155-156 (patched) > > > > > > Sorry I overlooked this in my last around of

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review175768 --- Ship it! Ship It! - Jiang Yan Xu On May 16, 2017, 4:09

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 12, 2017, 10:13 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 157-158 (original), 155-156 (patched) > > > > > > Sorry I overlooked this in my last around of

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated May 16, 2017, 11:09 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 12, 2017, 10:13 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 157-158 (original), 155-156 (patched) > > > > > > Sorry I overlooked this in my last around of

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 12, 2017, 5:13 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 157-158 (original), 155-156 (patched) > > > > > > Sorry I overlooked this in my last around of

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review174763 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp Lines 64

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated May 9, 2017, 11:59 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

> On May 9, 2017, 11:55 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Line 62 (original), 62 (patched) > > > > > > This is unnecessary? This comment is now on the `class

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review174391 --- Fix it, then Ship it! I can fix up the following the

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated April 29, 2017, 5:41 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/#review173411 --- src/slave/containerizer/mesos/isolators/xfs/utils.hpp Lines 46

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated April 25, 2017, 10:37 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 55895: Extract a BasicBlocks class for disk block arithmetic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55895/ --- (Updated April 24, 2017, 6:07 p.m.) Review request for mesos, Jie Yu and Jiang