Review Request 55901: [WIP] Added support for command health checks to the default executor.

2017-01-24 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, a

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

2017-01-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review162922 --- Patch looks great! Reviews applied: [55899, 55900, 55901] Passed

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

2017-01-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review162972 --- It looks like there's a deadlock in the cleanup path of the Agent/

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

2017-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review163363 --- src/checks/health_checker.hpp (line 137)

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

2017-01-28 Thread Gastón Kleiman
> On Jan. 28, 2017, 1:17 a.m., Vinod Kone wrote: > > src/checks/health_checker.hpp, line 137 > > > > > > we don't typically do `const` for POD types. > > > > s/_agentSpawnsCommandContainer/ Looks lke the re