Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-02-03 Thread Benjamin Mahler
> On Jan. 31, 2017, 6:32 p.m., Michael Park wrote: > > src/master/validation.cpp, lines 1674-1700 > > > > > > It's not clear to me why we need to unallocate the resources. > > > > Presumably the resources i

Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-02-03 Thread Benjamin Mahler
> On Jan. 28, 2017, 3:25 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 1654-1667 > > > > > > Did not quite catch up the `TODO` here, can you please elaborate for > > why want such a function? We ha

Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-01-31 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/#review163687 --- Fix it, then Ship it! src/master/validation.cpp (lines 1674 -

Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-01-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/#review163405 --- src/master/http.cpp (lines 4614 - 4615)

Re: Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-01-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/#review163091 --- Bad patch! Reviews applied: [55970, 55969, 55968, 55967, 55870, 5

Review Request 55970: Updated the master's HTTP operations to handle MULTI_ROLE changes.

2017-01-25 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55970/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Pa