Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

2017-02-03 Thread Benjamin Mahler
> On Jan. 30, 2017, 1:46 a.m., Guangya Liu wrote: > > src/master/master.cpp, lines 5620-5628 > > > > > > Same comments as /r/55971/ here Dropped per previous comments, would like to follow up and figure out what

Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

2017-02-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/#review163902 --- Fix it, then Ship it! src/master/master.cpp (line 5617)

Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

2017-02-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/#review163883 --- src/master/master.cpp (lines 5663 - 5667)

Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

2017-01-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/#review163455 --- src/master/master.cpp (lines 5620 - 5628)

Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

2017-01-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael