Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-02-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated Feb. 28, 2017, 3:48 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review167556 --- Fix it, then Ship it! src/common/protobuf_utils.hpp Lines 96-9

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-01 Thread Alexander Rukletsov
> On March 1, 2017, 7:46 p.m., Vinod Kone wrote: > > src/common/protobuf_utils.hpp > > Lines 96-98 (original), 98-100 (patched) > > > > > > The last sentence seems un-necssary because the it's clear from the > > ar

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-01 Thread Vinod Kone
> On March 1, 2017, 7:46 p.m., Vinod Kone wrote: > > src/common/protobuf_utils.hpp > > Lines 96-98 (original), 98-100 (patched) > > > > > > The last sentence seems un-necssary because the it's clear from the > > ar

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated March 7, 2017, 8:38 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated March 14, 2017, 2:05 p.m.) Review request for mesos, Gastón Kleiman an

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- (Updated March 15, 2017, 12:44 p.m.) Review request for mesos, Gastón Kleiman a

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-15 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review168999 --- src/common/protobuf_utils.hpp Lines 96 (patched)

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-15 Thread Vinod Kone
> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-15 Thread Gastón Kleiman
> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by

Re: Review Request 56017: Added a helper for building a task status from an existing one.

2017-03-15 Thread Alexander Rukletsov
> On March 15, 2017, 1:19 p.m., Gastón Kleiman wrote: > > src/common/protobuf_utils.hpp > > Lines 96 (patched) > > > > > > The implementation doesn't create a new task sttus message. It updates > > the one passed by