Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-02-02 Thread Jan Schlicht
> On Jan. 30, 2017, 10:24 a.m., Jan Schlicht wrote: > > src/tests/slave_validation_tests.cpp, line 282 > > > > > > Indent with 4 spaces. > > Greg Mann wrote: > Unfortunately, I think our style guide is ambiguous

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-02-01 Thread Greg Mann
> On Jan. 30, 2017, 9:24 a.m., Jan Schlicht wrote: > > src/tests/slave_validation_tests.cpp, line 282 > > > > > > Indent with 4 spaces. > > Greg Mann wrote: > Unfortunately, I think our style guide is ambiguous

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Greg Mann
> On Jan. 30, 2017, 9:24 a.m., Jan Schlicht wrote: > > src/tests/slave_validation_tests.cpp, line 282 > > > > > > Indent with 4 spaces. > > Greg Mann wrote: > Unfortunately, I think our style guide is ambiguous

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Greg Mann
> On Jan. 30, 2017, 9:24 a.m., Jan Schlicht wrote: > > src/tests/slave_validation_tests.cpp, line 282 > > > > > > Indent with 4 spaces. Unfortunately, I think our style guide is ambiguous on this point? And it seems

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/ --- (Updated Jan. 31, 2017, 10:19 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/ --- (Updated Jan. 31, 2017, 10:17 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/ --- (Updated Jan. 31, 2017, 10:13 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-31 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/#review163709 --- Fix it, then Ship it! src/tests/slave_validation_tests.cpp (li

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-30 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/#review163486 --- src/tests/slave_validation_tests.cpp (line 282)

Re: Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/#review163422 --- Patch looks great! Reviews applied: [55954, 55955, 56055] Passed

Review Request 56055: Added validation for 'LAUNCH_NESTED_CONTAINER_SESSION'.

2017-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56055/ --- Review request for mesos, Jan Schlicht and Vinod Kone. Repository: mesos Desc