Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review165246 --- Patch looks great! Reviews applied: [56327, 56328, 56330, 56371,

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/ --- (Updated 二月 11, 2017, 10:29 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review165214 --- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.c

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review164640 --- Maybe add a test to check master suppress/revive validation code p

Re: Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/#review164580 --- Patch looks great! Reviews applied: [56327, 56328, 56330, 56371,

Review Request 56378: Added test case for suppress and revive with multi role framework.

2017-02-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56378/ --- Review request for mesos, Benjamin Mahler and Jay Guo. Bugs: MESOS-6638 htt