Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 28, 2017, 6:24 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review166854 --- Ship it! Ship It! - Alexander Rojas On Feb. 22, 2017, 2:15

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review166631 --- Ship it! Ship It! - Vinod Kone On Feb. 22, 2017, 1:15 a.m.,

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 22, 2017, 1:15 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review166118 --- Lookin good include/mesos/authorizer/authorizer.proto (lines 29

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 3:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 17, 2017, 10:34 p.m.) Review request for mesos, Adam B,

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 16, 2017, 10:56 a.m., Alexander Rojas wrote: > > src/common/http.cpp, line 708 > > > > > > I have the feeling that `extractAuthorizationSubject` may be a better > > way of describing what is happening

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 4:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 4:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 133 > > > > > > How about using an `Option` here and returning > > `Subject()` in the case of `context.isNone()`? > > All calls

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review165825 --- src/common/http.hpp (line 133)

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

> On Feb. 14, 2017, 4:12 p.m., Jan Schlicht wrote: > > src/common/http.hpp, line 132 > > > > > > Why `const` when you're returning a value? so you cannot assign to the returned value, i.e. you cannot do

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review165511 --- This look great already. But I'll need more time to deeply review

Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till