Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-27 Thread Alexander Rojas
> On Feb. 27, 2017, 12:58 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, line 62 > > > > > > `static` keyword doesn't have that much use in a header. > > Greg Mann wrote: >

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-27 Thread Greg Mann
> On Feb. 27, 2017, 11:58 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, line 62 > > > > > > `static` keyword doesn't have that much use in a header. In this context, the

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 28, 2017, 6:13 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 28, 2017, 6:12 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review166851 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 62)

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 24, 2017, 12:05 a.m.) Review request for mesos, Adam B,

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review166588 --- Fix it, then Ship it!

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 22, 2017, 1:14 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-20 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review166116 --- Looks good for a foundation, but I haven't looked at the rest of

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 18, 2017, 2:54 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-17 Thread Greg Mann
> On Feb. 16, 2017, 10:45 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/http.cpp, lines 87-109 > > > > > > Why not going the fancy way and use `jsonify()`? > > Alexander Rojas wrote: > Just add this

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 10:33 p.m.) Review request for mesos, Adam B,

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-17 Thread Alexander Rojas
> On Feb. 16, 2017, 11:45 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/src/http.cpp, lines 87-109 > > > > > > Why not going the fancy way and use `jsonify()`? Just add this function in the same namespace as

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 5:31 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 17, 2017, 5:20 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review165857 --- 3rdparty/libprocess/include/process/http.hpp (lines 75 - 78)

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review165822 --- 3rdparty/libprocess/include/process/http.hpp (line 22)

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review165504 --- 3rdparty/libprocess/include/process/http.hpp (line 81)

Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

2017-02-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till