Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/ --- (Updated March 15, 2017, 11:01 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review169065 --- Can you split the change to add discard semantics to queue? That p

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/ --- (Updated March 21, 2017, 2:40 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-21 Thread Joseph Wu
> On March 15, 2017, 3:01 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/queue.hpp > > Lines 80-86 (patched) > > > > > > This looks racy: > > > > (1) `put()` hits line 48, found the prom

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review169658 --- Patch looks great! Reviews applied: [57399, 57821, 57358] Passed

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-24 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review170021 --- 3rdparty/libprocess/include/process/queue.hpp Line 58 (original),

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-03-29 Thread Joseph Wu
> On March 24, 2017, 9:09 a.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/queue.hpp > > Line 58 (original), 58 (patched) > > > > > > I was just testing this patch locally, and noticed that after applyin

Re: Review Request 57358: Implemented discard behavior in process::Queue.

2017-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/#review171034 --- 3rdparty/libprocess/include/process/queue.hpp Lines 73 (patched)