Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/#review169484 --- Fix it, then Ship it! LGTM! src/launcher/default_executor.cpp

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-16 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/ --- (Updated March 16, 2017, 6:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/#review169170 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp Lin

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/#review168773 --- Fix it, then Ship it! LGTM, but I want to make sure Jie reviews

Re: Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-11 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/#review168714 --- Patch looks great! Reviews applied: [57469] Passed command: expo

Review Request 57469: Made the default executor populate volume mappings for disk resources.

2017-03-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57469/ --- Review request for mesos, Gilbert Song and Vinod Kone. Bugs: MESOS-7225 htt