Re: Review Request 58040: Avoid various redundant copies.

2017-04-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/#review170913 --- Ship it! Let's get these in as they are strictly improvements.

Re: Review Request 58040: Avoid various redundant copies.

2017-04-03 Thread Benjamin Bannier
> On March 30, 2017, 10:36 a.m., Benjamin Bannier wrote: > > The changes here look good to me, but running > > > > % CHECKS='-*,performance-unnecessary-copy-initialization' > > ./support/mesos-tidy.sh > > > > still emits a lot of unneeded copy warnings. Could you have a look what > >

Re: Review Request 58040: Avoid various redundant copies.

2017-03-31 Thread Neil Conway
> On March 30, 2017, 8:36 a.m., Benjamin Bannier wrote: > > The changes here look good to me, but running > > > > % CHECKS='-*,performance-unnecessary-copy-initialization' > > ./support/mesos-tidy.sh > > > > still emits a lot of unneeded copy warnings. Could you have a look what > > o

Re: Review Request 58040: Avoid various redundant copies.

2017-03-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/#review170548 --- The changes here look good to me, but running % CHECKS='-*,pe

Re: Review Request 58040: Avoid various redundant copies.

2017-03-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/ --- (Updated March 30, 2017, 1:15 a.m.) Review request for mesos and Benjamin Banni

Review Request 58040: Avoid various redundant copies.

2017-03-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description