> On May 17, 2017, 4:29 p.m., Adam B wrote:
> > Seems like we're adding even more duplicate code into this v1 clone of
> > `roles()`. Can you find a way to reduce the redundance?
OK, let me take look and may submit some follow-up patches for it.
- Jay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated June 22, 2017, 2:02 a.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review175219
---
Seems like we're adding even more duplicate code into this v1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174594
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174543
---
Ship it!
Ship It!
- Alexander Rojas
On May 10, 2017, 3:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated May 10, 2017, 9:52 p.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174461
---
src/master/http.cpp
Line 3647 (original), 3670-3676 (patched)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review174166
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated May 8, 2017, 3:56 p.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review172335
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated April 19, 2017, 11:38 a.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review171736
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated April 12, 2017, 1:38 p.m.)
Review request for mesos, Adam B,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review171043
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
(Updated April 5, 2017, 1:47 a.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review170674
---
Patch looks great!
Reviews applied: [58095, 58096, 58097, 58099]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/
---
Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
Bugs:
17 matches
Mail list logo