Re: Review Request 58194: Hardened HTTP check tests.

2017-04-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/ --- (Updated April 24, 2017, 10:12 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-20 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review172469 --- Ship it! Ship It! - Gastón Kleiman On April 19, 2017, 3:16

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review172361 --- Patch looks great! Reviews applied: [58190, 58191, 58192, 58193,

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/ --- (Updated April 19, 2017, 3:16 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-12 Thread Vinod Kone
> On April 7, 2017, 12:31 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Line 837 (original), 839 (patched) > > > > > > Does this mean the test runs for atleast 1 second? If yes, that's > > unfortunate.

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-07 Thread Alexander Rukletsov
> On April 7, 2017, 12:31 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Line 837 (original), 839 (patched) > > > > > > Does this mean the test runs for atleast 1 second? If yes, that's > > unfortunate.

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-07 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review171339 --- Ship it! Ship It! - Gastón Kleiman On April 4, 2017, 10:24

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-07 Thread Gastón Kleiman
> On April 7, 2017, 12:31 a.m., Vinod Kone wrote: > > src/tests/check_tests.cpp > > Line 837 (original), 839 (patched) > > > > > > Does this mean the test runs for atleast 1 second? If yes, that's > > unfortunate.

Re: Review Request 58194: Hardened HTTP check tests.

2017-04-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/#review171298 --- src/tests/check_tests.cpp Line 837 (original), 839 (patched)

Review Request 58194: Hardened HTTP check tests.

2017-04-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58194/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos