Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- Review request for mesos, Joseph Wu and Kevin Klues. Bugs: MESOS-7310 https

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated April 12, 2017, 6:10 p.m.) Review request for mesos, Joseph Wu and Kev

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated April 12, 2017, 9:43 p.m.) Review request for mesos, Jason Lai, Joseph

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated April 12, 2017, 9:44 p.m.) Review request for mesos, Jason Lai, Joseph

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review171835 --- Patch looks great! Reviews applied: [58394] Passed command: expo

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review171950 --- Ship it! Ship It! - Jason Lai On April 12, 2017, 9:44 p.m.,

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review173674 --- src/python/.gitignore Lines 1 (patched)

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On May 2, 2017, 11:11 p.m., Kevin Klues wrote: > > src/python/.gitignore > > Lines 1 (patched) > > > > > > Why do you need .virtualenv in this folder? I wouldn't expect us to > > create a .virtualenv directory anywh

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated May 11, 2017, 6:34 p.m.) Review request for mesos, Jason Lai, Joseph W

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review174760 --- Patch looks great! Reviews applied: [58394] Passed command: expo

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review175967 --- bump - Eric Chung On May 11, 2017, 6:34 p.m., Eric Chung wrote:

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On May 2, 2017, 11:11 p.m., Kevin Klues wrote: > > src/python/lib/mesos/__init__.py > > Lines 1 (patched) > > > > > > I would exclude this from this commit. > > It is not used anywhere, therefore it should not be

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review178687 --- Patch looks great! Reviews applied: [58394] Passed command: supp

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On May 2, 2017, 11:11 p.m., Kevin Klues wrote: > > src/python/lib/mesos/__init__.py > > Lines 1 (patched) > > > > > > I would exclude this from this commit. > > It is not used anywhere, therefore it should not be

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated June 28, 2017, 6:55 p.m.) Review request for mesos, Jason Lai, Joseph

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179185 --- Bad patch! Reviews applied: [58394] Failed command: python suppo

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179253 --- Ship it! Please make the commit description more explicit by ad

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated June 29, 2017, 6:18 p.m.) Review request for mesos, Armand Grillet, Ja

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated June 29, 2017, 6:22 p.m.) Review request for mesos, Armand Grillet, Ja

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179666 --- bump - Eric Chung On June 29, 2017, 6:22 p.m., Eric Chung wrote

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179733 --- Bad patch! Reviews applied: [58394] Failed command: python suppo

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On July 5, 2017, 6:02 p.m., Eric Chung wrote: > > bump FYI the Mesos Reviewbot Windows reports a bad patch due to an error in `apply-reviews.py`, I doubt there is an issue with your review request. A fix has been merged a few hours ago: https://github.com/apache/mesos/commit/01fd1355cb3cd9b

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179757 --- Are we sure that we will be able to properly build the CLI into a

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On July 6, 2017, 6:40 a.m., Kevin Klues wrote: > > Are we sure that we will be able to properly build the CLI into a binary > > with this change? Or more accurately, are we sure we will be able to properly build the CLI into a binary once we start imporint libraries from this new location (I

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179759 --- src/cli_new/bootstrap Line 11 (original), 11 (patched)

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated July 6, 2017, 5:14 p.m.) Review request for mesos, Armand Grillet, Jas

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On July 6, 2017, 6:40 a.m., Kevin Klues wrote: > > Are we sure that we will be able to properly build the CLI into a binary > > with this change? > > Kevin Klues wrote: > Or more accurately, are we sure we will be able to properly build the CLI > into a binary once we start imporint libr

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179807 --- Ship it! Ship It! - Kevin Klues On July 6, 2017, 5:14 p.m.,

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On July 6, 2017, 6:50 a.m., Kevin Klues wrote: > > src/cli_new/bootstrap > > Line 11 (original), 11 (patched) > > > > > > Maybe add another variable here called: > > ``` > > MESOS_PYTHONDIR="$( cd ${CURRDIR}

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated July 6, 2017, 6:30 p.m.) Review request for mesos, Armand Grillet, Jas