Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-12 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs: MESOS-502

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/#review171840 --- Patch looks great! Reviews applied: [58408] Passed command: expo

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 13, 2017, 8:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 14, 2017, 12:24 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-14 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 14, 2017, 6:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/#review172055 --- src/slave/containerizer/mesos/provisioner/backends/copy.cpp Lines

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 17, 2017, 9:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-17 Thread Chun-Hung Hsiao
> On April 17, 2017, 12:03 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/copy.cpp > > Lines 193 (patched) > > > > > > What if `node->fts_info` is things like `FTS_DNR`, `FTS_ERR`, `FTS_NS

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

2017-04-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/#review172169 --- Fix it, then Ship it! src/slave/containerizer/mesos/provisione