Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-04 Thread Kapil Arya
> On May 4, 2017, 6:25 p.m., Jie Yu wrote: > > include/mesos/module/secretfetcher.hpp > > Lines 17 (patched) > > > > > > secret_fetcher.hpp > > > > (we have secret_generator.hpp). Let's make sure it's

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-04 Thread Jie Yu
> On May 4, 2017, 10:25 p.m., Jie Yu wrote: > > include/mesos/secret/fetcher.hpp > > Lines 17 (patched) > > > > > > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp > > Kapil Arya wrote: > I am not

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-04 Thread Kapil Arya
> On May 4, 2017, 6:25 p.m., Jie Yu wrote: > > include/mesos/secret/fetcher.hpp > > Lines 17 (patched) > > > > > > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp I am not sure so sure about it because

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review173966 --- include/mesos/module/secretfetcher.hpp Lines 17 (patched)

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 4, 2017, 4:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-05-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review173514 --- include/mesos/secret/secretfetcher.hpp Lines 27 (patched)

Re: Review Request 58759: Introduced SecretFetcher module interface.

2017-04-28 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated April 28, 2017, 2:50 p.m.) Review request for mesos, Gilbert Song,

Review Request 58759: Introduced SecretFetcher module interface.

2017-04-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- Review request for mesos and Gilbert Song. Repository: mesos Description