Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-19 Thread Joseph Wu
> On May 11, 2017, 1:53 a.m., Jie Yu wrote: > > src/local/local.cpp > > Lines 372-374 (patched) > > > > > > I'd suggest we put fetcher dir under work_dir as well for local mode so > > that all directories related to

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 19, 2017, 3:05 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174619 --- Ship it! Ship It! - Jie Yu On May 10, 2017, 8:32 p.m., Josep

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174618 --- Great clean up! src/local/local.cpp Lines 372-374 (patched)

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 10, 2017, 1:32 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 10, 2017, 1:24 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-09 Thread Jie Yu
> On May 8, 2017, 10:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 261 (patched) > > > > > > This patch is still missing cleanup for this directory. > > > > Before this patch, w

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/#review174232 --- Request for comment... src/slave/containerizer/fetcher.cpp Lines

Re: Review Request 58900: Changed the default fetcher cache directory.

2017-05-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- (Updated May 8, 2017, 3:20 p.m.) Review request for mesos and Jie Yu. Changes

Review Request 58900: Changed the default fetcher cache directory.

2017-05-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58900/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7304 https://issues.apache