Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- Review request for mesos, Adam B and Greg Mann. Bugs: MESOS-7415 https://is

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated May 23, 2017, 3:57 p.m.) Review request for mesos, Adam B and Greg Man

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review175814 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review175832 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated May 24, 2017, 3:32 p.m.) Review request for mesos, Adam B and Greg Man

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated May 30, 2017, 1:41 p.m.) Review request for mesos, Adam B and Greg Man

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review176304 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review176350 --- Patch looks great! Reviews applied: [59453, 58955, 58964, 59099,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review176726 --- src/master/http.cpp Lines 4477-4487 (patched)

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

> On June 2, 2017, 4:44 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 4482-4483 (patched) > > > > > > Following on my previous comment regarding calls to `approved` which > > return an error: let's try t

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review177553 --- src/master/http.cpp Lines 4377-4379 (patched)

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated June 12, 2017, 6:14 p.m.) Review request for mesos, Adam B, Greg Mann,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/ --- (Updated June 12, 2017, 7:30 p.m.) Review request for mesos, Adam B, Greg Mann,

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review177675 --- Fix it, then Ship it! Looks great - just one lil ancient includ

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

> On June 12, 2017, 11:57 p.m., Till Toenshoff wrote: > > src/master/master.hpp > > Line 30 (original), 30 (patched) > > > > > > Aren't we missing > > ``` > > #include > > ``` Nope, the authorizer is f

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

> On June 12, 2017, 9:57 p.m., Till Toenshoff wrote: > > src/master/master.hpp > > Line 30 (original), 30 (patched) > > > > > > Aren't we missing > > ``` > > #include > > ``` > > Alexander Rojas wrote:

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

> On June 12, 2017, 11:57 p.m., Till Toenshoff wrote: > > src/master/master.hpp > > Line 30 (original), 30 (patched) > > > > > > Aren't we missing > > ``` > > #include > > ``` > > Alexander Rojas wrote

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

> On June 12, 2017, 11:57 p.m., Till Toenshoff wrote: > > src/master/master.hpp > > Line 30 (original), 30 (patched) > > > > > > Aren't we missing > > ``` > > #include > > ``` > > Alexander Rojas wrote