Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191281 --- Ship it! Ship It! - Gilbert Song On Nov. 16, 2017, 1:34 p.m.

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Nov. 16, 2017, 9:34 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li
> On Nov. 16, 2017, 7:29 p.m., Gilbert Song wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Lines 1773 (patched) > > > > > > Did build you test and run it? Sorry missed this one. - Zhi

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191230 --- src/tests/containerizer/nested_mesos_containerizer_tests.cpp Line

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-16 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Nov. 16, 2017, 5:02 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review191156 --- Fix it, then Ship it! src/tests/containerizer/nested_mesos_con

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-11-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review190241 --- Ship it! Ship It! - Gilbert Song On Oct. 27, 2017, 11:02 a.m

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-10-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Oct. 27, 2017, 6:02 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-10-26 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review189351 --- Fix it, then Ship it! src/tests/containerizer/nested_mesos_con

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-09-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- (Updated Sept. 26, 2017, 6:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 59687: Added tests for recovering ContainerConfig.

2017-09-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/#review186192 --- Fix it, then Ship it! This patch LGTM. src/tests/containerize

Review Request 59687: Added tests for recovering ContainerConfig.

2017-05-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59687/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-6894 http