Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review178554 --- Ship it! Ship It! - Joseph Wu On June 7, 2017, 12:50 p.m., A

Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review177397 --- Patch looks great! Reviews applied: [59891] Passed command: expo

Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review177220 --- Patch looks great! Reviews applied: [59891] Passed command: supp

Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/ --- (Updated June 7, 2017, 7:50 p.m.) Review request for mesos, Jeff Coffler, John

Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-07 Thread Andrew Schwartzmeyer
> On June 7, 2017, 7:39 p.m., Michael Park wrote: > > src/tests/health_check_tests.cpp > > Lines 46-48 (patched) > > > > > > Do we need a macro here? > > > > Can we just do it inline? Something like: > >

Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review177210 --- src/tests/health_check_tests.cpp Lines 46-48 (patched)

Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

2017-06-07 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. Bug