Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Oct. 17, 2017, 7:13 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Sept. 19, 2017, 3:01 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 511 (original), 586-589 (patched) > > > > > > I still think it is better to raise the

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review185637 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review184636 --- Ship it! Ship It! - Qian Zhang On Sept. 6, 2017, 1:57 a.m.,

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Sept. 5, 2017, 5:57 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review184517 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Aug. 30, 2017, 11:26 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 23, 2017, 5:52 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 394 (original), 436 (patched) > > > > > > So here an empty `Info` object is put into `infos`?

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183693 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 23, 2017, 9:52 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 394 (original), 436 (patched) > > > > > > So here an empty `Info` object is put into `infos`?

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183586 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183456 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 21, 2017, 4:32 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Line 244 (original), 245 (patched) > > > > > > So here we only count `network/cni` isolator and

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 21, 2017, 8:32 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Line 244 (original), 245 (patched) > > > > > > So here we only count `network/cni` isolator and

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Aug. 21, 2017, 10:01 p.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183307 --- src/slave/containerizer/mesos/containerizer.cpp Line 244

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated July 29, 2017, 12:01 a.m.) Review request for mesos, Qian Zhang and