Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review181395 --- Ship it! Left a reply to the issue for further discussion

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 2:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 272-275 (patched) > > > > > > Aside from styling/convention, would this require defer? > > James Peach wrote: >

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 9:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 272-275 (patched) > > > > > > Aside from styling/convention, would this require defer? > > James Peach wrote: >

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 2:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 272-275 (patched) > > > > > > Aside from styling/convention, would this require defer? > > James Peach wrote: >

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/ --- (Updated July 19, 2017, 3:05 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 60791: Add fetcher cache space usage metrics.

> On July 18, 2017, 9:16 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/fetcher.cpp > > Lines 266-267 (original), 266-275 (patched) > > > > > > Outside the fetcher I think we use a convention like this: > >

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180862 --- Haven't looked at tests but perhaps we can discuss the current

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/ --- (Updated July 18, 2017, 2:13 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180702 --- docs/monitoring.md Lines 1258-1261 (patched)

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180492 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/#review180281 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 60791: Add fetcher cache space usage metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60791/ --- Review request for mesos. Bugs: MESOS-7782