Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180892 --- 3rdparty/libprocess/src/openssl.cpp Lines 124 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 21, 2017, 11:29 a.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:51 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 294 (patched) > > > > > > Judging from the NGINX sources, it appears that `OPENSSL_NO_ECDH` got > > introduced

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181052 --- 3rdparty/libprocess/src/openssl.cpp Lines 294 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 124 (patched) > > > > > > ``` > > "NOTE: OpenSSL versions below 1.0.2 support only..." > > ``` > >

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

> On July 20, 2017, 3:21 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/openssl.cpp > > Lines 118 (patched) > > > > > > We are still missing the documentation in `docs/ssl.md`. Oops - drop this - Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181045 --- 3rdparty/libprocess/src/openssl.cpp Lines 118 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 20, 2017, 2:37 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review181030 --- 3rdparty/libprocess/src/openssl.cpp Lines 297 (patched)

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180925 --- Thanks for this Alexander - this is a great improvement to our

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180916 --- Hey! This looks great. I have a few remarks. 1) The test in

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180889 --- Patch looks great! Reviews applied: [60913] Passed command:

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 18, 2017, 2:13 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/#review180685 --- Patch looks great! Reviews applied: [60913] Passed command:

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 17, 2017, 5:31 p.m.) Review request for mesos, Jie Yu and Till

Re: Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- (Updated July 17, 2017, 5:31 p.m.) Review request for mesos, Jie Yu and Till

Review Request 60913: Adds support for OpenSSL's ECDH handshake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60913/ --- Review request for mesos, Jie Yu and Till Toenshoff. Bugs: MESOS-7792