Re: Review Request 61033: Added missing metrics to tests.

2017-07-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181743 --- Ship it! Ship It! - Vinod Kone On July 28, 2017, 2:40 p.m.,

Re: Review Request 61033: Added missing metrics to tests.

2017-07-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/ --- (Updated July 28, 2017, 2:40 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 61033: Added missing metrics to tests.

2017-07-28 Thread Alexander Rukletsov
> On July 25, 2017, 10:12 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp > > Line 1364 (original), 1365 (patched) > > > > > > I see that you sneaked in a style fix here. Please avoid when possible. I felt cr

Re: Review Request 61033: Added missing metrics to tests.

2017-07-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181396 --- src/tests/slave_tests.cpp Line 1364 (original), 1365 (patched)

Re: Review Request 61033: Added missing metrics to tests.

2017-07-22 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/#review181175 --- Ship it! Ship It! - Armand Grillet On July 21, 2017, 2:32 p.

Review Request 61033: Added missing metrics to tests.

2017-07-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61033/ --- Review request for mesos, Armand Grillet and Vinod Kone. Repository: mesos De