Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-13 Thread Andrei Budnik
> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Benno Evers
> On Sept. 12, 2017, 11:07 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Lines 1317-1319 (original), 1333-1337 (patched) > > > > > > Instead of checking a flag, why not replacing

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Benno Evers
> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Alexander Rukletsov
> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185157 --- For the default executor, a cleaner approach would be to

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185156 --- src/docker/executor.cpp Lines 141 (patched)

Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-11 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Bugs: