Review Request 62477: Added the gone agents to the master registry.

2017-09-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7444 https://issues.ap

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186174 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2017, 8:27 p.m.,

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186176 --- src/master/master.hpp Lines 2306 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186178 --- src/master/registry.proto Lines 60 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-26 Thread Anand Mazumdar
> On Sept. 25, 2017, 11:56 p.m., Vinod Kone wrote: > > src/master/master.hpp > > Lines 2306 (patched) > > > > > > Looks like this is not possible according to the code in the next > > review. If so, can you return

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-26 Thread Vinod Kone
> On Sept. 26, 2017, 12:02 a.m., Vinod Kone wrote: > > src/master/registry.proto > > Lines 60 (patched) > > > > > > s/master/operator/ ? > > Anand Mazumdar wrote: > hmm, not sure about this. The operator inititat

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/#review186304 --- src/tests/registrar_tests.cpp Lines 384-385 (patched)

Re: Review Request 62477: Added the gone agents to the master registry.

2017-09-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62477/ --- (Updated Sept. 26, 2017, 8:25 p.m.) Review request for mesos and Vinod Kone.