Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Kapil Arya.

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186554 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186569 --- configure.ac Lines 239 (patched)

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Andrei Budnik
> On Sept. 28, 2017, 5:22 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 239 (patched) > > > > > > Let's call this `libtool-wrappers` to match what we use in the code (it > > also refers to multiple wrappe

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186603 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-29 Thread Andrei Budnik
> On Sept. 28, 2017, 5:22 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 243 (patched) > > > > > > Let's not explicitly specify the different branches here and instead > > let autoconf handle it for us, se

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186663 --- Fix it, then Ship it! configure.ac Lines 234-238 (patched)

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186668 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-29 Thread Andrei Budnik
> On Sept. 29, 2017, 12:30 p.m., Benjamin Bannier wrote: > > configure.ac > > Lines 234-238 (patched) > > > > > > We currently have two such comment blocks which are not identical, one > > in `configure.ac` and one

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-09-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186696 --- PASS: Mesos patch 62661 was successfully built and tested. Review

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-10-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review186991 --- Ship it! So is the idea to turn on this flag for ASF CI builds?

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-10-03 Thread Andrei Budnik
> On Oct. 3, 2017, 6:58 p.m., Kapil Arya wrote: > > So is the idea to turn on this flag for ASF CI builds? Yes, exactly. - Andrei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62661/#review