Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-10-26 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/ --- Review request for mesos, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu. Re

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-10-26 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189340 --- Ship it! Ship It! - Jeff Coffler On Oct. 26, 2017, 4:27 p.m.

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-11-02 Thread Aaron Wood via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189962 --- 3rdparty/stout/include/stout/windows/os.hpp Line 669 (original),

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-11-02 Thread Aaron Wood via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review189963 --- Ship it! Ship It! - Aaron Wood On Nov. 2, 2017, 8:39 p.m., A

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-11-02 Thread Andrew Schwartzmeyer
> On Nov. 2, 2017, 1:51 p.m., Aaron Wood wrote: > > 3rdparty/stout/include/stout/windows/os.hpp > > Line 669 (original), 670 (patched) > > > > > > How about doing `if (job_handle.get_handle()) {` instead? Loosely, b

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-11-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review190504 --- Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 8:39 p.m., Andre

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

2017-11-10 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review190754 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:39 p.m.,