Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. Repository

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review190064 --- src/resource_provider/message.hpp Lines 42 (patched)

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

> On Nov. 3, 2017, 10:19 p.m., Greg Mann wrote: > > src/resource_provider/message.hpp > > Lines 42 (patched) > > > > > > I'm tempted to use `UUID` here instead of `string`, but we would > > probably just end up conve

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 6, 2017, 1:38 p.m.) Review request for mesos, Chun-Hung Hsiao, Ji

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review190189 --- Fix it, then Ship it! src/resource_provider/manager.cpp Lines

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

> On Nov. 6, 2017, 10:51 p.m., Greg Mann wrote: > > src/resource_provider/manager.cpp > > Lines 368-371 (patched) > > > > > > I found a couple other spots where we indent four spaces in this > > situation, perhaps w

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 6, 2017, 11:12 p.m.) Review request for mesos, Chun-Hung Hsiao, J

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review189897 --- Fix it, then Ship it! src/resource_provider/message.hpp Line 3

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 7, 2017, 1:25 p.m.) Review request for mesos, Chun-Hung Hsiao, Ji

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 7, 2017, 1:40 p.m.) Review request for mesos, Chun-Hung Hsiao, Ji

Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- (Updated Nov. 7, 2017, 11 p.m.) Review request for mesos, Chun-Hung Hsiao, Jie