Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Greg Mann, Jie Yu, an

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review192205 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6812 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 29, 2017, 4:13 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6900 (patched) > > > > > > See my comments in https://reviews.apache.org/r/63843/ > > > > What if both the RP and the agent kno

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 29, 2017, 5:27 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 29, 2017, 3:13 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6900 (patched) > > > > > > See my comments in https://reviews.apache.org/r/63843/ > > > > What if both the RP and the agent kno

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 29, 2017, 3:13 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6900 (patched) > > > > > > See my comments in https://reviews.apache.org/r/63843/ > > > > What if both the RP and the agent kno

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review192104 --- src/slave/slave.cpp Lines 6900 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 28, 2017, 10:32 p.m.) Review request for mesos, Greg Mann, Jie Yu

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191908 --- Fix it, then Ship it! src/slave/slave.cpp Lines 6895 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 24, 2017, 3:08 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191668 --- src/slave/slave.cpp Lines 6753 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 18, 2017, 1:54 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 6800 (patched) > > > > > > I feel we should also call `updateOfferOpreation` here with a terminal > > state (OFFER_OPERATION_DROPPED).

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 21, 2017, 10:08 p.m.) Review request for mesos, Greg Mann, Jie Yu

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191425 --- src/slave/slave.cpp Lines 6800 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 16, 2017, 1:23 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 6722 (original), 6722 (patched) > > > > > > I suggest we change this to `UPDATE_STATE` to align with the RP API > > because we also upda

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191108 --- src/slave/slave.cpp Line 6722 (original), 6722 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 13, 2017, 11:07 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3800-3803 (patched) > > > > > > Am I correct in thinking that we usually don't use quotes around IDs > > that we generate ourselves

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 15, 2017, 6:31 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review190887 --- src/slave/slave.cpp Lines 3791 (patched)

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 13, 2017, 7:33 p.m.) Review request for mesos, Jie Yu and Jan Sch