Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review192503 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 28, 2017,

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

> On Nov. 21, 2017, 6:04 p.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 203-204 (patched) > > > > > > I believe we prefer writing `CopyFrom()` explicitly, no? > > Jiang Yan Xu wrote: >

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? > > Jiang Yan Xu wrote: > I suppose I

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? I suppose I need to handle it there too

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review191605 --- src/internal/devolve.cpp Lines 194-196 (original), 194-196