Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 17, 2018, 8:44 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review195636 --- Fix it, then Ship it! src/docker/docker.cpp Lines 752 (patched

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 12, 2018, 2:34 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Jan. 10, 2018, 12:30 p.m., Alexander Rukletsov wrote: > > src/docker/docker.cpp > > Lines 744-749 (patched) > > > > > > Does it make sense to also remove the default here? > > https://github.com/apache/mesos/bl

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review195130 --- src/docker/docker.cpp Lines 744-749 (patched)

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 10, 2018, 1:23 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194986 --- Fix it, then Ship it! src/docker/docker.cpp Lines 742-744 (ori

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 5, 2018, 10:25 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194884 --- Fix it, then Ship it! src/docker/docker.cpp Line 741 (original

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 5, 2018, 6:31 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Jan. 4, 2018, 8:42 p.m., Jie Yu wrote: > > I like the direction in the latest diff (platform specific defaults). > > > > One question is: what's the difference between nat and bridge? are they the > > same? If yes, can we not have NAT in the API? In other words, BRIDGE on > > Windows will

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Jan. 5, 2018, 12:29 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Jan. 4, 2018, 8:42 p.m., Jie Yu wrote: > > I like the direction in the latest diff (platform specific defaults). > > > > One question is: what's the difference between nat and bridge? are they the > > same? If yes, can we not have NAT in the API? In other words, BRIDGE on > > Windows will

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194784 --- I like the direction in the latest diff (platform specific default

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review193173 --- src/docker/docker.cpp Lines 741-744 (original), 747-782 (patched)

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Dec. 7, 2017, 12:04 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Dec. 1, 2017, 1:47 a.m., Jie Yu wrote: > > src/docker/docker.cpp > > Lines 742-743 (original), 742-752 (patched) > > > > > > It's weird that user specifies HOST in the API, but we use "nat" > > instead. > >

Re: Review Request 63860: Windows: Mapped the Docker network info types.

> On Dec. 1, 2017, 1:47 a.m., Jie Yu wrote: > > src/docker/docker.cpp > > Lines 742-743 (original), 742-752 (patched) > > > > > > It's weird that user specifies HOST in the API, but we use "nat" > > instead. > >

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review192429 --- src/docker/docker.cpp Lines 742-743 (original), 742-752 (patched)

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Nov. 27, 2017, 5:37 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Nov. 17, 2017, 10:37 p.m.) Review request for mesos, Andrew Schwartzme