Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 22, 2018, 11:18 p.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review198109 --- src/tests/environment.cpp Line 80 (original), 85-87 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 22, 2018, 1:48 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review197704 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 16, 2018,

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 16, 2018, 11:49 p.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review197346 --- This patch looks like it's still pending updates (i.e. it has

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 13, 2018, 12:24 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review197130 --- src/tests/health_check_tests.cpp Lines 109 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review196738 --- src/tests/environment.cpp Lines 350-356 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 30, 2018, 10:21 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 29, 2018, 6:48 p.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 23, 2018, 7:03 p.m., Gaston Kleiman wrote: > > src/tests/health_check_tests.cpp > > Lines 109 (patched) > > > > > > Why can't we use an official image that Microsoft will keep up-to-date? It's buggy. You

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 22, 2018, 11:07 p.m., Joseph Wu wrote: > > src/tests/environment.cpp > > Lines 378-389 (patched) > > > > > > So these tests will be disabled until the user runs `docker pull > >

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review196055 --- src/tests/health_check_tests.cpp Lines 109 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review195947 --- src/tests/environment.cpp Lines 344-348 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 17, 2018, 12:12 p.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 17, 2018, 12:08 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 16, 2018, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 10, 2018, 1:41 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 120-122 (patched) > > > > > > Why only on windows? > > Akash Gupta wrote: > The original code didn't

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 10, 2018, 1:41 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 120-122 (patched) > > > > > > Why only on windows? > > Akash Gupta wrote: > The original code didn't

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 10, 2018, 1:41 p.m., Alexander Rukletsov wrote: > > src/tests/health_check_tests.cpp > > Lines 120-122 (patched) > > > > > > Why only on windows? The original code didn't pre-pull the images, because the

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review195134 --- src/tests/health_check_tests.cpp Lines 120-122 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Jan. 8, 2018, 11:46 p.m., Gaston Kleiman wrote: > > src/tests/health_check_tests.cpp > > Lines 103 (patched) > > > > > > Can we use `#ifdef __WINDOWS__` here and in the other files below? > > > > Also

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 10, 2018, 1:41 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review194994 --- src/tests/environment.cpp Lines 334-335 (patched)

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Jan. 5, 2018, 12:33 a.m.) Review request for mesos, Alexander

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Dec. 14, 2017, noon) Review request for mesos, Andrew Schwartzmeyer,

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review193640 --- FAIL: Some Mesos tests failed. Reviews applied: `['63859',

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Dec. 13, 2017, 1:48 a.m.) Review request for mesos, Andrew

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Dec. 7, 2017, 10:30 p.m., Andrew Schwartzmeyer wrote: > > src/tests/health_check_tests.cpp > > Lines 102-111 (patched) > > > > > > Can we reuse those added to the other test file? Yeah. I can add the constant

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review193181 --- src/tests/health_check_tests.cpp Lines 102-111 (patched)

Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos