Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199862 --- src/master/master.cpp Lines 6027 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 22, 2018, 11:26 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 19, 2018, 11:13 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log > > Gaston Kleiman wrote: > Do we have an official rule

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5969 (patched) > > > > > > whitespace after block > > > > `const UUID& ...` This one is moved at the end of the

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log > > Gaston Kleiman wrote: > Do we have an official rule

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 19, 2018, 9:50 a.m., Zhitao Li wrote: > > src/master/master.cpp > > Lines 5934 (patched) > > > > > > whitespace line after multi-line log Do we have an official rule saying that there should be an empty

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199426 --- src/master/master.cpp Lines 5934 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 13, 2018, 4:19 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 5960 (patched) > > > > > > Can we move this to? > > > > `std::move(statusUuid.toBytes())` > > > > Looks like

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 14, 2018, 4:50 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

> On March 13, 2018, 4:19 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 5960 (patched) > > > > > > Can we move this to? > > > > `std::move(statusUuid.toBytes())` > > > > Looks like

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated March 14, 2018, 2:01 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199128 --- Fix it, then Ship it! src/master/master.cpp Lines 5960

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Feb. 1, 2018, 3:52 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196535 --- PASS: Mesos patch 64618 was successfully built and tested.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Jan. 30, 2018, 1:22 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196528 --- src/master/master.cpp Lines 5892-5893 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196377 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196375 --- PASS: Mesos patch 64618 was successfully built and tested.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Jan. 26, 2018, 2:09 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196301 --- src/master/master.cpp Lines 5841-5850 (patched)

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196082 --- FAIL: Mesos tests failed to build. Reviews applied: `['65300',