Re: Review Request 64685: Improved the comment around the union in ns::clone().

2017-12-22 Thread Alexander Rukletsov
> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote: > > src/linux/ns.cpp > > Line 320 (original), 320 (patched) > > > > > > Since you are at it, could you make the first part a full sentence, > > e.g., > > >

Re: Review Request 64685: Improved the comment around the union in ns::clone().

2017-12-22 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/#review194427 --- Fix it, then Ship it! src/linux/ns.cpp Line 320 (original), 32

Re: Review Request 64685: Improved the comment around the union in ns::clone().

2017-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/ --- (Updated Dec. 22, 2017, 1:42 p.m.) Review request for mesos, Armand Grillet, Be

Re: Review Request 64685: Improved the comment around the union in ns::clone().

2017-12-18 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/#review194089 --- Ship it! Ship It! - Armand Grillet On Dec. 18, 2017, 7:06 p.

Review Request 64685: Improved the comment around the union in ns::clone().

2017-12-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64685/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park. R