Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195498 --- Ship it! Ship It! - Joseph Wu On Jan. 16, 2018, 12:05 p.m.,

Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/ --- (Updated Jan. 16, 2018, 12:05 p.m.) Review request for mesos, Akash Gupta, Gilb

Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Andrew Schwartzmeyer
> On Jan. 16, 2018, 10:58 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/which.hpp > > Lines 53-56 (patched) > > > > > > I think the reason for allowing the caller to specify the extension is > >

Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Andrew Schwartzmeyer
> On Jan. 16, 2018, 10:58 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/windows/which.hpp > > Lines 53-56 (patched) > > > > > > I think the reason for allowing the caller to specify the extension is > >

Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195480 --- 3rdparty/stout/include/stout/os/windows/which.hpp Lines 53-56 (pa

Re: Review Request 65144: Ported `os::which` to Windows.

2018-01-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/#review195475 --- Ship it! Ship It! - Jie Yu On Jan. 14, 2018, 2:01 a.m., Andr

Review Request 65144: Ported `os::which` to Windows.

2018-01-12 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65144/ --- Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Bugs: MESOS-8225