Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated March 2, 2018, 10:46 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review198470 --- Fix it, then Ship it! src/master/master.cpp Lines 7642

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 15, 2018, 11:55 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7647-7654 (patched) > > > > > > I'm sitting here trying to think of ways we might avoid crashing if the > > framework subscribes

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 3, 2018, 12:06 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7594-7597 (original), 7609-7612 (patched) > > > > > > Is this function now only called with resources from already-existing > >

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 16, 2018, 1:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 7652 (patched) > > > > > > s/ "operation/<< "operation/ I don't think we need or want an extra function call here. I ended

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 16, 2018, 12:55 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7645 (patched) > > > > > > s/`RunTaskMessage`, see/`RunTaskMessage`. See/ Hmm ... I am not a native speaker, but wouldn't

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated Feb. 16, 2018, 3:12 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review197651 --- src/master/master.cpp Lines 7652 (patched)

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 15, 2018, 11:55 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7647-7654 (patched) > > > > > > I'm sitting here trying to think of ways we might avoid crashing if the > > framework subscribes

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review197641 --- src/master/master.cpp Lines 7643 (patched)

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/ --- (Updated Feb. 14, 2018, 3:21 p.m.) Review request for mesos, Greg Mann, Jie